Improve Python 3 compatibility of the build

wdas / SeExpr

SeExpr is an embeddable, arithmetic expression language that enables flexible artistic control and customization in creating computer graphics images. Example uses include procedural geometry synthesis, image synthesis, simulation control, crowd animation, and geometry deformation. https://wdas.github.io/SeExpr

https://www.disneyanimation.com/open-source/seexpr/

Other

405 stars 86 forks source link

Improve Python 3 compatibility of the build #64

Closed mruegenberg closed 7 years ago

mruegenberg commented 7 years ago

I added some changes to fix some problems I had on Arch Linux with Python 3 and GCC 6.2.1:

If Python 3 is detected, boost_python3 is used. Since some distributions instead call that library e.g boost_python35, that case is handled as well
Use Python 3-compatible SIP string calls
Always enable -Wno-date-time, since without it the build fails for me. Adding this should be no problem, since that flag is supported since at least GCC 4.8

davvid commented 7 years ago

Hi @mruegenberg this looks good and we'd like to merge this but it has conflicts since the PR was opened. Would you mind rebasing? Hopefully we can get the code to a nice python2+3 compatible place.

Thanks again!

mruegenberg commented 7 years ago

Hmm, I'd try to fix the Python 3 compatibility again, but am still bumping against #58. Are there plans to fix that one for good?

mruegenberg commented 7 years ago

I've now created a new fork to resolve other issues first. My earlier work on Python 3 is in a separate branch.

davvid commented 7 years ago

Hello, thanks again for the python3 improvements. I just wanted to note that #71 has been merged, which hopefully pushes us forward on this topic (python3) in general.

Let me know if this PR still needs to be open, or if we should close it in case the changes in the other PR are superset of the ones here.

mruegenberg commented 7 years ago

I'll close this for now and just make the current SeExpr work on my machine bit by bit (with different changes packed in separate PRs). This way, I'll re-add Python 3 compatibility in time.