davvid
commented
7 years ago You know much more about windows than I do, and your explanations make sense to me. If other windows users need cmake options for DLLs they can always add them in the future. Thanks again!
Properly (kind of) fixed build on Windows. This PR doesn't modify Linux/MacOS behavior. It was tested with Visual Studio 2017. It seems to work fine, but there are a few things that I'm not really confident in:
693fdf5 I had to add a TYPE in the my_enable_if failure case. I think the whole point of it not having the TYPE definition is to fail to compile if accidently used, but I don't know how Gcc and MSVC handle those kind of template constructs...
bba7589 On Windows, you can't link agaisnt a dll without exporting classes definitions to a .lib. Since that would require a lot of additional code (every "public" classes of the library would need to use the __declspec(dllexport) decorator) I decided to make the whole lib static on Windows.
As always, feel free to tell me if anything's wrong, if you'd prefer the lib to stay a dll on Windows, etc.