search

wdas / SeExpr

SeExpr is an embeddable, arithmetic expression language that enables flexible artistic control and customization in creating computer graphics images. Example uses include procedural geometry synthesis, image synthesis, simulation control, crowd animation, and geometry deformation. https://wdas.github.io/SeExpr
https://www.disneyanimation.com/open-source/seexpr/
Other
405 stars 86 forks source link

fixed a crash when using string with binary and comparison operators … #92

Closed ix-dcourtois closed 5 years ago

ix-dcourtois commented 5 years ago

…and fixed incorrect inequlity operator for strings.

I also added 2 tests that were leading to crashes before the fixes. I couldn't run the test though since I'm on Windows, and I can't get them to run (I had a lot of tweaks to do to make them compile, but it still didn't run so I'll probably try again later and submit another pull request when everything works)

If you have any comment, feel free to share !

ix-dcourtois commented 5 years ago

Hello, Anyone here ? :p

davvid commented 5 years ago

Hi @dcourtois, thanks for the ping. This is on my merge todo list for Monday. Thanks again for these fixes and tests.

ix-dcourtois commented 5 years ago

Great news ! Thanks for merging them :)