wdas / SeExpr

SeExpr is an embeddable, arithmetic expression language that enables flexible artistic control and customization in creating computer graphics images. Example uses include procedural geometry synthesis, image synthesis, simulation control, crowd animation, and geometry deformation. https://wdas.github.io/SeExpr
https://www.disneyanimation.com/open-source/seexpr/
Other
405 stars 86 forks source link

fixed dumb mistake in string un-escaping #99

Closed ix-dcourtois closed 4 years ago

ix-dcourtois commented 4 years ago

In one of my previous merge-request, I fixed a problem with strings special characters, but the small helper used was not very robust (the original merge-request was specifically added this to fix a common use-case in our integration, and the unit test was tailored to that use-case, so I totally missed the case that this current MR fixes)

Anyway now this should work properly (I updated the unit test to catch the problem of the current implementation) Hopefully since (almost) nobody uses strings, this pull request will be accepted before anyone notices :p

jberlin commented 4 years ago

looks good -- thanks!