search

wdas / partio

C++ (with python bindings) library for easily reading/writing/manipulating common animation particle formats such as PDB, BGEO, PTC. https://wdas.github.io/partio
https://www.disneyanimation.com/open-source/partio/
Other
458 stars 133 forks source link

Please provide a versioned library #82

Closed luyatshimbalanga closed 3 years ago

luyatshimbalanga commented 4 years ago

Hello, I am a Fedora contributor aiming to package partio. The review process suggested to include the versionned library on src/lib/CMakeLists.txt using the following line:

set_target_properties(partio PROPERTIES
    OUTPUT_NAME partio POSITION_INDEPENDENT_CODE ON
    VERSION ${CMAKE_PROJECT_VERSION}
    SOVERSION 1 
)

Edit: correct line. Hopefully, you will provide the suggestion on the next release. Thanks in advance.

davvid commented 4 years ago

Thanks for the sug @luyatshimbalanga -- yes, this would be good to do.

danfe commented 3 years ago

For ${CMAKE_PROJECT_VERSION} expansion to work, project() should be called with VERSION argument in the top-level CMakeLists.txt.