zlib API bleeds through header

wdas / ptex

Per-Face Texture Mapping for Production Rendering https://wdas.github.io/ptex

https://www.disneyanimation.com/open-source/ptex/

Other

681 stars 140 forks source link

zlib API bleeds through header #40

Closed bfloch closed 5 years ago

bfloch commented 5 years ago

PTexReader.h includes zlib.h for the z_stream_s member but this also has the side-effect of leaving symbols in other libraries for no reason.

Compare: https://github.com/PixarAnimationStudios/USD/issues/790

brentb commented 5 years ago

PtexReader.h is not part of the public API (applications are expected to go through Ptexture::open or PtexCache::get) so I'm not sure how PtexReader.h is causing problems. There's no problem with including zlib.h and using z_stream_s in the implementation, is there?

bfloch commented 5 years ago

Hi, thanks for the quick reply. Yes you are right. I was to quick to jump to that conclusion based on Usd's dependencies on zlib.

I'll have to keep looking.