pandas.value_counts is deprecated

wdecoster / NanoPlot

Plotting scripts for long read sequencing data

http://nanoplot.bioinf.be

MIT License

419 stars 47 forks source link

pandas.value_counts is deprecated #348

Closed jodjo86 closed 10 months ago

jodjo86 commented 10 months ago

I got this error:

/home/user/miniforge3/envs/nano/lib/python3.10/site-packages/nanoplotter/spatial_heatmap.py:76: FutureWarning:
pandas.value_counts is deprecated and will be removed in a future version. Use pd.Series(obj).value_counts() instead.

To correct the problem, I replaced line 76 of the spatial_heatmap.py with this :

valueCounts = pd.Series(array).value_counts()

Sorry for not making a pull request.

wdecoster commented 10 months ago

Thank you for the detailed report and solution! Okay, I will fix this - or that pull request is still welcome ;)