search

wdecoster / NanoPlot

Plotting scripts for long read sequencing data
http://nanoplot.bioinf.be
MIT License
401 stars 48 forks source link

Q10 to Q30 quality score thresholds not available in latest NanoPlot version #371

Closed sandratra-rab closed 3 weeks ago

sandratra-rab commented 1 month ago

Hi, I saw that the latest nanomath commit is the following "update quality score thresholds" and that you said that the new 10, 15, 20, 25 and 30 cutoffs should be available with the latest NanoPlot version #366. However, when trying to download the latest staphb NanoPlot docker image (pulled as a Singularity image) and both latest NanoPlot bioconda and pip3 packages but they were all built using nanomath==1.3.0 (and nanomath==1.4.0 does not seem to exist when I try to manually update it).

So if I'm not wrong, no current installation mode seems to include the latest code modifications for the 10, 15, 20, 25 and 30 cutoffs.

Did I miss something ? Is there a way to use NanoPlot with the latest nanomath update ?

wdecoster commented 1 month ago

Hmm I didn't realize that! I have just pushed nanomath 1.4.0 to pypi, I think conda will follow soon. What I should really be doing is migrating the code from nanomath into nanoplot itself to get rid of these version issues...

sandratra-rab commented 4 weeks ago

Indeed, it would be easier to maintain this way.

Thank you, I've just updated nanomath and it worked like a charm!

wdecoster commented 4 weeks ago

Awesome, thanks for the feedback!