Closed ASLeonard closed 1 year ago
Hi, thanks for the suggestion and changes! As you can see, the tests are not passing at the moment, and it looks like this is the case because you didn't edit the test functions. I would use an Option<String>
as the type for this argument, or is there a reason you implemented it as is?
is there a reason you implemented it as is?
Learning rust on the fly, so plenty of room for improvement 😃.
I've changed it to Option<String>
and modified the test to match the function signature. Ultimately probably should add an explicit test for using the --reference
arg, but at least this is backward compatible.
Thanks!
This was helpful for non-standard references or if there were any issues with firewalls like