search

wdecoster / nanocomp

Comparison of multiple long read datasets
MIT License
113 stars 9 forks source link

Seaborn requirement should be added to setup #43

Closed seanrj-conagen closed 3 years ago

seanrj-conagen commented 3 years ago

Installing nanocomp using pip on a fresh python3 environment lacks the seaborn prereq.

seaborn should be added to setup.py.

Right about here, I think: https://github.com/wdecoster/nanocomp/blob/fd900d05bb2fb8a7189a0c733647f2aa0c9e9ee6/setup.py#L40

wdecoster commented 3 years ago

Hi,

Thanks for reporting this. But in fact, seaborn is not used anymore. I noticed we forgot to remove an import statement, probably leading to the error you saw. We will fix it soon!

Cheers, Wouter

seanrj-conagen commented 3 years ago

Thanks. Yes, it was having an error on the import statement at the top of utils.py.

wdecoster commented 3 years ago

This should be solved in NanoComp v1.14.1, please let us know if you notice further issues!