search

wdfw-fp / CreelEstimates

WDFW freshwater creel estimates
GNU General Public License v3.0
11 stars 3 forks source link

Use of WDFW stat weeks to define week time_strata #10

Closed evanbooher closed 2 years ago

evanbooher commented 2 years ago

@daauerbach @kalebentley Trashon pointed out that we're not using the "WDFW statistical week" that is used within our agency and among co-managers to define estimation periods at the weekly time-step. He connected with Angelika, whom shared this file. We could either use the file as-is to define weeks in the script, or code our way to the same result?

Stat Weeks 95 22.xls

daauerbach commented 2 years ago

done in d6a88d5 to make weeks Sunday to Saturday

kalebentley commented 2 years ago

Not to be annoying but I don't know that we want to use the "WDFW statistical week" (which I now realize is Sun - Sat). I see merit if there are specific deliverables tied to this report grouping. However, since we are using daytype & week to create groupings of "more-similar" days, using Mon-Sun makes more sense (to me) given that a Saturday and Sunday next to each other are likely going to have more similar effort and catch rates than a Sat. and Sun. separated by six days (which is what the "WDFW statistical week" does). Also, I use the Mon-Sat version of a week in my Creel Schedule Generator script.

Overall, I vote to convert back to the original version. Thoughts?

daauerbach commented 2 years ago

Well…I can include another param/input to allow switching. Fairly painless to code, but one more thing to keep track of…

On Thu, Jul 21, 2022 at 2:45 PM Kale Bentley @.***> wrote:

Not to be annoying but I don't know that we want to use the "WDFW statistical week" (which I now realize is Sun - Sat). I see merit if there are specific deliverables tied to this report grouping. However, since we are using daytype & week to create groupings of "more-similar" days, using Mon-Sun makes more sense (to me) given that a Saturday and Sunday next to each other are likely going to have more similar effort and catch rates than a Sat. and Sun. separated by six days (which is what the "WDFW statistical week" does). Also, I use the Mon-Sat version of a week in my Creel Schedule Generator script.

Overall, I vote to convert back to the original version. Thoughts?

— Reply to this email directly, view it on GitHub https://github.com/wdfw-fp/CreelPointEstimate/issues/10#issuecomment-1191965492, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEAKV3IAUA3SCFJQPVM52CTVVHAFXANCNFSM522BS5CQ . You are receiving this because you modified the open/close state.Message ID: @.***>

kalebentley commented 2 years ago

I'd just have one option and leave it the way it was before

evanbooher commented 2 years ago

I agree with Kale that Monday - Sunday makes more sense given the make up of the daytype strata and agreement with other DFW reporting (CRC). Dan I was a bit confused circling back on this, since the DFW stat week is Sunday-Monday, but what’s coded here is the tribal “management week” from that doc you had opened up earlier today?

On Jul 21, 2022, at 3:40 PM, Kale Bentley @.***> wrote:

 I'd just have one option and leave it the way it was before

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

evanbooher commented 2 years ago

I think this is essentially resolved - using %W, with weeks defined as Monday - Sunday. If users want to use the "WDFW stat week" that remains an option on an analysis/script basis, where they would edit weeks as %W + 1. Thanks all for the discussion, which essentially brought us back to where we started!