wdfw-fp / CreelEstimates

WDFW freshwater creel estimates
GNU General Public License v3.0
11 stars 3 forks source link

merge Drano branch back to main #46

Closed kalebentley closed 5 months ago

kalebentley commented 5 months ago

The overall goal of the "Drano" branch was to update the data wrangling functions and .Rmd script so that it could accommodate the creel study design used on Drano Lake in 2023.

The main differences between our "standard" creel study design and Drano's were 1.) effort counts categories - instead of counting vehicle and trailers (standard), the Drano creel counted boats [vessels] and bank anglers, 2.) every [index] effort count survey for Drano was treated as a census count.

After reviewing the existing data wrangling functions, I ended up updating almost every function between the "fetch_dwg" function and the "summary_BSS" chunk. The YAML has several new parameters that are used inside several of the update functions (e.g., study_design). The updates add flexibility to the data wrangling and will make it easier to adapt the overall CreelAnalysis to future/alternative creel study designs (e.g., R5/LCR steelhead).

I have tested updates in the Drano branch by comparing estimates of total catch and effort for four different fisheries generated using the original (OG) main branch functions and the update Drano branch functions. The four fisheries were: 1.) Hoh winter steelhead 2023-24, 2.) Skagit fall salmon 2021, 3.) Skagit winter steelhead 2023, and 4.) Skykomish summer Chinook 2021. Aside from the estimates generated for Section 1 (out of 5) for the Skagit fall salmon 2021, every other total estimate of effort and catch by section for each fishery were almost identical between the OG main and the Drano functions. Small difference were expected given slight changes in angler type categorizations (updated functions added transparency & flexibility). It's worth figuring out the Section 1 difference...but feel confident the functions are working as expected and should work for both past and future datasets.