Open jaredpalmer opened 8 years ago
This is interesting, but is there anything wrong with:
// Example middleware hooks (psuedo code)
// modules/server.js
...
import { createServer } from 'react-project/server'
..
import morgan from 'morgan'
import newrelic from 'newrelic'
...
const server = createServer({
renderDocument,
renderApp,
routes
})
if (process.env.NODE_ENV === 'development') {
server.use(morgan('dev'))
}
if (process.env.NODE_ENV === 'production') {
server.use(morgan('combined'))
server.locals.newrelic = newrelic
}
server.start()
I'm a little hesitant to become a wrapper over express.
@ryanflorence middleware needs to be defined before the routes are defined.
@ryanflorence 100% agree, but if we don't want to wrap express, then maybe we should do the following:
server.js
blueprint filereact-project
server api^ how about that?
LGTM
I actually want to just put morgan in by default
Pretty sure this is now solved with the createServer
API.
// server.js
...
import morgan from 'morgan'
...
const server = createServer(getApp)
process.env.NODE_ENV !== 'production' ? server.use(morgan('dev')) : server.use(morgan('combined'))
server.start()
I'm leaving this open because I am interested in having nicer hooks around things as we learn what is commonly added/replaced/removed.
fair enough.