search

wdoekes / asterisk-chan-dongle

chan_dongle channel driver for Huawei UMTS cards, works with Asterisk 14+
Other
300 stars 105 forks source link

Instruction for automatic gain control and jitter buffer #33

Closed garronej closed 7 years ago

garronej commented 7 years ago

Hi @wdoekes,

I realised that indeed the fix that I made you do regaring the jitter buffer with asterisk 12+ prevent asterisk from crashing but still the jitter buffer feature in dongle.conf does not work.

To be forgiven I updated the readme with the proper instructions for enabling Jitter buffer in the dialplan.

I also added instruction about how to enable automatic gain control, it improve greately the quality of the calls.

Regards,

wdoekes commented 7 years ago

And please squash these changes into a single commit. Separate commits only make sense for separate functionality. We don't need fixups of a single changeset into the main repo.

garronej commented 7 years ago

Ok I will do that right. I will close this PR and open a new one.

wdoekes commented 7 years ago

No need to close the PR.

You can simply update your changeset and force-push over it. It will update this PR automatically.

See git rebase -i HEAD~4 with fixup, and git commit --amend and git push -f and so forth.

garronej commented 7 years ago

Thanks I did not manage to do that myself but I will now for next time 👍