Closed miopa closed 4 years ago
Hi!
Sorry for not responding sooner.
If you can split these up into three separate pull requests, I promise to look at them within a week :)
No feedback. I know it's my fault, sorry about that.
I cannot vouch for the necessity of these patches. Please reopen 3 PRs if you still want them.
Ok, I'll do that when I have some time to put my mind to it. BTW I never understood your request, what is the difference between merging a single commit from the PR with splitting the commits in separate PRs?
Then I can merge two and nitpick about the third :+1:
This is especially important if the three commits are unrelated. Or if there is a delay between the merge and conflicts arise (in some). Or one or more of the commits is rejected.
I know it's slightly more work for you, but it makes things so much easier for reviewers. If your git-fu is up to it, it should be a breeze. Practice makes perfect :grin:
NOTICE
when dongle disconnects or initializes'\n'
or'\r'
)