wdonne / traefikoidc

BSD 2-Clause "Simplified" License
2 stars 2 forks source link

Logging doesn't include the actual errors #7

Closed phrontizo closed 2 months ago

phrontizo commented 3 months ago

There are a few spots where an error is logged via fmt.Println where the actual error is discarded. https://github.com/wdonne/traefikoidc/blob/81875684ea38d38ce96f82e03dc39a71b1821d30/oidc.go#L187 is the one that caused me headaches in tracking down some issues with AD token iss claims.

Line 187 I changed to fmt.Println("Invalid token: ", err), but I am a go novice so perhaps there would be a better way. I also wonder if they should go to stderr rather than stdout. Might not make any difference depending how Traefik handles the streams internally.

wdonne commented 2 months ago

Fixed in version 1.2.1.