Closed snodnipper closed 6 years ago
What is the state of this PR? What are the plans of merging (or not?) this?
Hopefully @ShibaBandit can find some time to review the code.
@boldtrn I published uk.os.vt:vt-legacy-parser:2.0.7
to maven central, which might be of interest in the short-term.
I'll try to look into this today.
Thank you, this would be highly appreciated.
uk.os.vt:vt-legacy-parser:2.0.7
In the short term I switched to this repo, thanks.
@snodnipper I've reviewed the changes and added some comments. Whenever you get a chance to review the comments we can proceed forward. Sorry I took way too long to get back to you on this pull request, got distracted with some other tasks.
Thanks for proceeding so fast here and for providing such a great library :+1:
I think things left to do before merge are:
What will be the allowed min Android API Level after the merged changes, i.e. could it be like 15?
@devemux86 I don't believe this will achieve API Level 15 - it looks like we have some uses of the static methods in java.util.Objects, which are available above API 19 (Android 4.4.+).
Perhaps we get this in and discuss pushing it lower?
https://github.com/wdtinc/mapbox-vector-tile-java/blob/933fa04e2cc5629bfc1b99582da8ab170535b702/src/main/java/com/wdtinc/mapbox_vector_tile/adapt/jts/TileGeomResult.java#L30 https://github.com/wdtinc/mapbox-vector-tile-java/blob/933fa04e2cc5629bfc1b99582da8ab170535b702/src/main/java/com/wdtinc/mapbox_vector_tile/adapt/jts/UserDataKeyValueMapConverter.java#L39
Perhaps we get this in and discuss pushing it lower?
Sure, that would be good!
Wondering about protobuf-java
dependency on Android too, are its versions after 2 compiled with Java 8?
@devemux86 it looks like Google compile at level 1.6, which is what most core libraries still do. It looks like we can bump the protobuf-java version at some point.
https://github.com/google/protobuf/blob/master/java/pom.xml#L99
@ShibaBandit I have updated the code to remove new lines etc. The only Javadoc warnings I get are in MvtValue, which could be done as a separate PR.
Ping me if there is more that you'd like 👍
Will the library compile configuration change to e.g. 1.7 with the changes?
@devemux86 I don't see why it should - you can build Java 1.8 just fine with the latest Android build tools. I only expect problems with unsupported methods / classes on old Android API levels...syntax should be ok.
As @snodnipper said, I think the language level itself is probably fine as long as the code is supported.
Support legacy Android (tested on API 21 / Android 5.0 / Lollipop)
If you'd prefer this PR clean then I can remove the Javadoc / Findbugs changes