search

wdtinc / mapbox-vector-tile-java

Java Mapbox Vector Tile Library for Encoding/Decoding
Apache License 2.0
147 stars 73 forks source link

Upgrade to locationtech JTS core 1.16.1 #32

Closed ShibaBandit closed 5 years ago

ShibaBandit commented 5 years ago

Upgrade to latest JTS core release of 1.16.1.

ShibaBandit commented 5 years ago

Closed via #33

devemux86 commented 5 years ago

Note that there are reports that JTS 1.16 requires latest Android 7 Nougat (API 24):

D8: Default interface methods are only supported starting with Android N (--min-api 24):
org.locationtech.jts.geom.Coordinate org.locationtech.jts.geom.CoordinateSequence.createCoordinate()

See also https://github.com/locationtech/jts/issues/145

That's why several projects remain still on JTS 1.15 to maintain Android compatibility, like VTM and GraphHopper.

ShibaBandit commented 5 years ago

@devemux86 Thank you for bringing this to my attention. I wanted to upgrade to the latest JTS to get all of the bug fixes. I think it's safe to use to sub out the JTS core version to 1.15 also in any downstream builds as a work around. Let me think on this if I should revert to 1.15 or 1.15.1.

devemux86 commented 5 years ago

Let me think on this if I should revert to 1.15 or 1.15.1.

We have tested JTS 1.15.1 successfully also on older Android. :slightly_smiling_face: https://github.com/graphhopper/graphhopper/pull/1507

ShibaBandit commented 5 years ago

Reading that locationtech link, it doesn't sound like they are doing any android workarounds anytime soon. Reverting would still be a net upgrade from 1.15 to 1.15.1... might do that here in a bit because I don't want to upset the android users.

ShibaBandit commented 5 years ago

Will close this and make a new issue for 1.15.1