search

wduquette / tcl-quill

Build tool for Tcl/Tk projects
BSD 2-Clause "Simplified" License
10 stars 2 forks source link

Some corrections for Windows #2

Closed effelsberg closed 10 years ago

effelsberg commented 10 years ago

1. In element_app.tcl, appElement:

file attributes -permissions is not available under Windows.

2. In plat.tcl, id:

Windows may report itself e.g. as "Windows NT" and not simply Windows. I suggest to use this match:

[string match Windows* $::tcl_platform(os)]

3. In plat.tcl, GetPathTo tclsh:

You need to dispatch this to tclsh.exe under Windows.

wduquette commented 10 years ago

Correct on all counts, and thank you for the input. I'll get these taken care of.

What command line shell are you using?

wduquette commented 10 years ago

These should now be fixed. For #1, Quill simply doesn't try to make the file executable on Window. I may have to revisit that. For #2, I use [string match] as suggested. For #3, Quill adds .exe when looking for programs on the PATH in Windows. The changes all work on OS X; testing on Windows would be helpful.