search

we-are-triing / prova

9 stars 4 forks source link

Remove the polyfills #2

Open coltpini opened 7 years ago

coltpini commented 7 years ago

Use the npm module require the polyfills from NPM. then Yarn can take care of duplication. @webcomponents/webcomponentsjs

we-are-triing commented 7 years ago

The internal battle I am having here is that the project should determine if the polyfills are there or not. So being able to pass in the polyfills, but not require them. So I don't think it is the correct course of action to include the polyfills in the storybook, but allow the path (URL) to be passed in when instantiated in the project. So I think I am going to rename this to "make polyfills optional", then in the readme it can describe how to include the polyfills in your project, as well as add the polyfills to the starter in the correct way.