search

we-bridge / vagrant-ansible-symfony

A template Vagrant Symfony2 project setup, supporting mixed Linux/OSX/Windows host environments
7 stars 5 forks source link

Encapsulate app container setup in separate role #21

Closed cbrunnkvist closed 9 years ago

cbrunnkvist commented 9 years ago

I had a case where I needed to set up a machine to run the Symfony CMF, and it's 90% similar to this box with the exception for some app paths and that you don't want provision to run the Symfony installer.

This patch adds webapp-container role that takes care of setting up the VirtualHost and FPM process group, so that webapp can be commented out as needed.

allan-simon commented 9 years ago

do you feel like explaining the role in the README, because the name of the different role start to get more and more obscure for newcomers

cbrunnkvist commented 9 years ago

You know what I think of documenting implementation... It's basically comments. :lipstick: :pig: ;-)

Wait, I'll come up with something.

allan-simon commented 9 years ago

thanks, here that was not documenting the implementation, but a user facing feature , as you mean the role file to be editable by the user as a normal usage, so they go to know what it does, especially when you introduce project-specific vocabulary.