search

we-bridge / vagrant-ansible-symfony

A template Vagrant Symfony2 project setup, supporting mixed Linux/OSX/Windows host environments
7 stars 5 forks source link

removed unused port #7

Closed allan-simon closed 9 years ago

allan-simon commented 9 years ago

I'm pretty sure we don't use it anymore and it was here because of some intermediate step testing ?

If not, a comment in the vagrant file to explain the purpose of that port forwarding would be welcome

cbrunnkvist commented 9 years ago

I know what it's for, it's for ./app/console server:run! But the perceived convenience is quickly undone when you realize that it binds to 127.0.0.1 only, while port forwarding will reach the non-local interface. So, you would need to tell it where to bind e.g. ./app console server:run 0.0.0.0:8000.

cbrunnkvist commented 9 years ago

Arguably, dev's are gonna add it back in case they need it.

Arguably, having it in there ain't gonna hurt and will save someone a vagrant reload.

I don't know ~~~~ already removed it so let's keep it that way. :)