Fix fstring ast locations

we-like-parsers / cpython

Here we work on integrating pegen into CPython; use branch 'pegen'

https://github.com/gvanrossum/pegen

Other

1 stars 0 forks source link

Fix fstring ast locations #169

Closed lysnikolaou closed 2 years ago

lysnikolaou commented 3 years ago

Fixes all test_fstring.test_ast_linenumbers* tests
Adds some more checks in the tests and fixes some wrong assumptions of the past

Resolves #155.

lysnikolaou commented 3 years ago

@pablogsal @isidentical @FFY00 Left some questions/comments I'd like some help with.

github-actions[bot] commented 3 years ago

This PR is stale because it has been open for 30 days with no activity.

lysnikolaou commented 2 years ago

@pablogsal @isidentical Found some bugs we had over here, which was the underlying cause for some of the work-arounds I had implemented here. I think this is now ready for review, whenever you have time.

lysnikolaou commented 2 years ago

@isidentical Thanks for the quick review! Have addressed all of your comments.