search

we-like-parsers / cpython

Here we work on integrating pegen into CPython; use branch 'pegen'
https://github.com/gvanrossum/pegen
Other
1 stars 0 forks source link

Are we allowing space between '!' and 'r/a/s'? #196

Closed lysnikolaou closed 1 year ago

lysnikolaou commented 1 year ago

Had a brief discussion with Mark and Guido during the sprints earlier this month on this, and the feeling I got is that we shouldn't allow this. What do you think?

pablogsal commented 1 year ago

I concur, I think there is no good reason to offer more flexibility here. The only question is how hard is this to implement

lysnikolaou commented 1 year ago

Oh, it turns out this is already implemented here! https://github.com/we-like-parsers/cpython/blob/09e77326574c046219c946bba34b098f0a682bb4/Parser/action_helpers.c#L1074-L1084

So, just close this and leave it as is?

pablogsal commented 1 year ago

I'm +1 on that. @isidentical ?

isidentical commented 1 year ago

Yep, makes perfect sense to me.