search

we-like-parsers / pegen_experiments

Experiments for the official PEG parser generator for Python
https://github.com/python/cpython/tree/master/Tools/peg_generator
Other
275 stars 29 forks source link

Use list instead of set in collect_todo #232

Closed lysnikolaou closed 4 years ago

lysnikolaou commented 4 years ago

This way the parser gets generated deterministically and can be included to version control, which is needed when integrating pegen to CPython.

lysnikolaou commented 4 years ago

Do you think that adding parse.c to version control is a good idea, since its generation is not random anymore?

pablogsal commented 4 years ago

Do you think that adding parse.c to version control is a good idea, since its generation is not random anymore?

I would be +1

gvanrossum commented 4 years ago

Thanks! I take it that a bit of this now needs to be down-ported to we-like-parsers?

lysnikolaou commented 4 years ago

Thanks! I take it that a bit of this now needs to be down-ported to we-like-parsers?

Yeah, I'm on it.