weDevsOfficial / wp-user-frontend

A WordPress plugin that brings many backend functionality to the site frontend
https://wordpress.org/plugins/wp-user-frontend/
227 stars 146 forks source link

fix: AllowDynamicProperty warning #1466

Closed sapayth closed 4 months ago

sapayth commented 4 months ago

Some of our plugin pages were showing PHP AllowDynamicProperty warning for PHP 8.* users

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The changes involve refactoring several classes within the project to remove the AllowDynamicProperties attribute and improve instance management through the use of centralized container properties. This enhances code organization and maintainability by encapsulating instances within a single property, making the structure more modular and easier to extend.

Changes

Files Change Summary
Lib/invisible_recaptcha.php Removed #[AllowDynamicProperties] attribute and adjusted class formatting.
admin/class-admin-settings.php Removed AllowDynamicProperties import and attribute from WPUF_Admin_Settings class.
includes/Admin.php Refactored Admin class to use a container for instance management, replacing individual properties.
includes/Admin/Forms/... Removed AllowDynamicProperties and updated form builder management in Admin_Form and Form classes.
includes/Admin/Forms/...Templates/ Added checks for existence of variables and removed AllowDynamicProperties in Post_Form_Template_WooCommerce and Pro_Form_Preview_EDD.
includes/Ajax/Frontend_Form_Ajax.php Removed fully-qualified AllowDynamicProperties usage.
includes/Fields/Form_Field_Post_Taxonomy.php Removed #[AllowDynamicProperties] attribute and import statement.
includes/Frontend.php Refactored to use a container for instance management instead of individual properties.
includes/Pro_Upgrades.php Updated register_pro_fields method to use the container array for managing pro_fields.
includes/Setup_Wizard.php Added custom_admin_bar_styles method and removed emoji styles from setup_wizard.
languages/wp-user-frontend.pot Updated various strings, labels, and messages in the translation file.
package.json Incremented version number from "4.0.8" to "4.0.9".
wpuf.php Introduced $container property in WP_User_Frontend to hold class instances, refactoring the instantiation process.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WP_User_Frontend
    participant Admin
    participant Ajax
    participant Component

    User->>WP_User_Frontend: Initialize
    WP_User_Frontend->>Admin: Instantiate if is_admin()
    Admin-->>WP_User_Frontend: Instance stored in container
    WP_User_Frontend->>Ajax: Instantiate if DOING_AJAX
    Ajax-->>WP_User_Frontend: Instance stored in container
    WP_User_Frontend->>Component: Instantiate various components
    Component-->>WP_User_Frontend: Instances stored in container
    User->>WP_User_Frontend: Access instance from container
    WP_User_Frontend->>User: Return instance

Poem

In the code where instances used to roam, We found a better, organized home. No more dynamic properties to see, Just neat containers, filled with glee. Version bumped, to four point nine, Our plugin shines, in organized design. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.