search

weDevsOfficial / wp-user-frontend

A WordPress plugin that brings many backend functionality to the site frontend
https://wordpress.org/plugins/wp-user-frontend/
227 stars 146 forks source link

enhance: dacimal value for subscription pack #1482

Closed sapayth closed 2 months ago

sapayth commented 2 months ago

fixes #498

Issue: Subscription pack pricing is not saving any decimal value.

Scenario: Subscription > Create New > Set Decimal Value > Save > Decimal value is not taken

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes introduced in this pull request enhance input handling for decimal numbers in the SectionInputField.vue file and improve billing amount precision in the Subscription class. The input field now accepts the period key, allowing for decimal entries, while the billing amount is now processed as a float to prevent loss of precision in subscription billing calculations.

Changes

File Change Summary
assets/js/components/subscriptions/... Added the period key '.' to the processNumber function to allow decimal input.
includes/Api/Subscription.php Changed the handling of billing_amount from integer to float to preserve decimal values.

Assessment against linked issues

Objective Addressed Explanation
Added form limit message and refactor form schedule message (#498) ❌ No changes related to form limits or messages were made.

🐰 In fields where numbers dance,
A period now takes a chance.
With billing precise, no cents to lose,
Our input's enhanced, we gladly choose!
Hopping along, we celebrate,
These changes make our work first-rate! 🎉

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 2d97a719b8e0adb01812f94f41180bf934f5150e and e9c610b6746a2cb2cc54b8fae02d42810b601f36.
Files ignored due to path filters (1) * `assets/js/subscriptions.min.js` is excluded by `!**/*.min.js`
Files selected for processing (2) * assets/js/components/subscriptions/SectionInputField.vue (1 hunks) * includes/Api/Subscription.php (1 hunks)
Additional comments not posted (2)
assets/js/components/subscriptions/SectionInputField.vue (1)
`125-125`: **LGTM!** The addition of the period key to the allowed keys list enables decimal input in numeric fields, aligning with the PR objective. The change is localized and does not introduce any apparent issues.
includes/Api/Subscription.php (1)
`394-394`: **Excellent update to preserve decimal precision in billing amounts!** Switching from `(int)` to `floatval()` for the `billing_amount` variable is a crucial improvement. It ensures that decimal values entered for subscription prices are accurately preserved throughout the billing calculations. This change is particularly important for subscription-based services where prices often include cents. Truncating to integers could lead to inaccuracies and confusion. Great catch and a valuable update!
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.