search

weacast / weacast-probe

Probing forecast model plugin for Weacast
MIT License
4 stars 1 forks source link

Probing of direction elements can fail #2

Closed claustres closed 6 years ago

claustres commented 6 years ago

It seems that sometimes probe results are created in doublon and with a single direction component. This is probably related to concurrent probing on both elements, as we perform a full feature update not patch.

Performing patch will remove doublon. However, we should also ensure that both components of a direction are probed in sequence so that all required values are present to compute the final direction value.

claustres commented 6 years ago

This behavior is amplified by loaders because in this case the download order is not controlled by Weacast application. To mitigate this download order has been changed in krawler so that elements and times are processed sequentially. If the number of concurrent loader tasks is lower than the total number of elements this should be fine.

claustres commented 6 years ago

The concurrency problem might also arise on probe creation because we do not check if a result already exist in this case before creating. We probably should add an check a unique constraint on forecastTime and perform a patch in this case.