search

weahforsage / react-native-animated-pagination-dots

MIT License
248 stars 34 forks source link

Problem when the device rotates #3

Closed Angelk90 closed 3 years ago

Angelk90 commented 3 years ago

Hi @weahforsage , it seems that when the device rotates or is rotated, the pagination no longer works, I also tried with your example, but it gives problems.

I don't know if the problem is: const {width} = Dimensions.get('screen');, that when the device rotates it doesn't update its dimensions or anything.

weahforsage commented 3 years ago

I should've test on landscape. I'll add it later

Angelk90 commented 3 years ago

@weahforsage : Are there any news?

weahforsage commented 3 years ago

@weahforsage : Are there any news?

This one would take a little bit time, I cannot give you any ETA at this moment.

fjmorant commented 3 years ago

@weahforsage created a PR to solve this issue https://github.com/weahforsage/react-native-animated-pagination-dots/pull/7

weahforsage commented 3 years ago

@weahforsage created a PR to solve this issue https://github.com/weahforsage/react-native-animated-pagination-dots/pull/7

I'll review that as soon as I can. Thank you for contributing.

fjmorant commented 3 years ago

@weahforsage nice, we are using this branch in our app and works all well if you need any help in understanding the changes please give me a shout

fjmorant commented 3 years ago

@weahforsage @redk1 any news about merging and having this PR in the main repo? https://github.com/weahforsage/react-native-animated-pagination-dots/pull/7 thx

weahforsage commented 3 years ago

@weahforsage @redk1 any news about merging and having this PR in the main repo? #7 thx

Merged fb2f553. Thanks for contributing.