search

wealdtech / go-ens

Apache License 2.0
90 stars 33 forks source link

Reverse resolution is returning invalid records #29

Closed 0xfornax closed 1 year ago

0xfornax commented 1 year ago

According to ENS documentation, the reverse record of an address is only valid if the forward resolution of that ENS name matches the address.

Current behavior: The library is showing invalid ENS names as the result of reverse resolution calls.

Expected behavior: The library should follow the ENS spec and validate if the reverse record is valid.

mcdee commented 1 year ago

That documentation says "accurate", not "valid". It is valid for multiple addresses to point to the same ENS domains, as it is valid for multiple ENS domains to point to the same address.

The choice as to if to use an address that points to a given ENS domain which does not then itself resolve back to the address is up to the user, and not something that should be enforced in the library.