wealdtech / go-ens

Apache License 2.0
90 stars 35 forks source link

ENSIP-10: Subdomain resolution #40

Open pikonha opened 6 months ago

pikonha commented 6 months ago

ENSIP-10: Subdomain resolution

Description

This PR implements the ENSIP-10 feature that makes it possible for subdomains to be resolved to their respective address.

The implementation was based on the ENS' Universal Resolver implementation, taking advantage of the findResolver subdomain resolution.

In general, the Universal Resolver utilizes fewer RPC calls, It is deployed on all major Ethereum networks such as Mainnet and Sepolia and is widely used by well known JS libraries that interact with Ethereum, see Viem's implementation.

Related Issue

This was part of the solution proposed by #38. The CCIP-Read from an offchain data source will be implemented on a future PR given its complexity.

Changes

Changes to Core Features:

Additional Notes

There are 2 failing tests on the main branch that are the only ones that are failing:

Cheers from the Blockful team 👋🏼