Radio buttons are rendering as check boxes

wealthbot-io / wealthbot

Use wealthbot.io to easily setup your own wealth management platform ⛺

Other

675 stars 158 forks source link

Radio buttons are rendering as check boxes #111

Closed lahiiru closed 6 years ago

lahiiru commented 6 years ago

For the stages > 1.0.0 (stable), radio buttons are rendered as check boxes. Tested on CentOS 7, Ubuntu latest with php 5.6. I'm running app using Symfony built-in server, using dev environment

Example routes, /client/profile/step-one /client/profile/step-three

This cause to break javascript queries.

azatyan commented 6 years ago

Hello @lahiiru you're right, but currently we plans to rewrite all the system with the new market needs. So we don't support this version. Any way, you're open to change the code, fix it and send us an pull request! https://github.com/wealthbot-io/wealthbot/blob/master/CONTRIBUTING.md

Thank you!

lancehaynie commented 6 years ago

If you can give me at least a little guidance I would be happy to take a look. I have never built a project on Symfony and Twig so I am a bit lost as to where to start. Employment on the Client side is doing the same thing. I know it is in the _employment_information_form_type_fields.html.twig file; or at least it is referenced there. But I am unsure of how to change from checkbox to radio.

lancehaynie commented 6 years ago

@azatyan @lahiiru I just submitted a pull request that fixes the radio buttons rendering as checkboxes. It also preserves checkboxes that should be checkboxes.

vlad-ko commented 6 years ago

Thank you. I have merged your PR