The NICKSERV code doesn't seem correct

weannounce / arrnounced

Notify Sonarr/Radarr/Lidarr of tracker IRC announcements.

22 stars 3 forks source link

The NICKSERV code doesn't seem correct #15

Closed samw15 closed 4 years ago

samw15 commented 4 years ago

It looks like the code in irc.py tries to authenticate with the command "NICKSERV". I believe it should be a PRIVMSG, like:

            logger.info("Identifying with NICKSERV")
            await self.rawmsg(
                "PRIVMSG", "NICKSERV", "IDENTIFY" , self.tracker_config.irc_ident_password
            )

(sorry for not doing a proper PR, I was just looking at the code)

weannounce commented 4 years ago

Yeah, that seems correct. Weird, because the identification has been working. Maybe the servers are lenient in that aspect? I pushed the update here a8644b39ff59fd285fdebe8f81d2feeeec6b26c8

Always good with another set of eyes on things. Thanks

samw15 commented 4 years ago

I later noticed that some servers seem to have NICKSERV as some kind of alias/wrapper. Perhaps a "native" command is considered more secure than a PRIVMSG.