search

wearable-learning-cloud-platform / wlcp-issues

0 stars 0 forks source link

Game Player Display Text + Display Photo Bug #216

Closed mmicciolo closed 2 years ago

mmicciolo commented 2 years ago

There is a bug when connecting to a game twice with a display text an display photo as the first state the text gets stuck at connecting...

image

This isn't a real connectivity issue but a bug with how some parts of the game player arent being reset when a user disconnects.

Steps to reproduce this bug:

  1. Open a new tab / window of WLCP
  2. Start a tangrams race instance in the game manager.
  3. Click the home button then click on game player tile
  4. Enter game pin and select player 1. Once it loads disconnect.
  5. Dont refresh the page.
  6. Click on game player tile again
  7. Enter game pin and select player 1
  8. Shows connecting... text but game still fully works
mmicciolo commented 2 years ago

This bug has been fixed and temporarily deployed to production (master) : http://new.wearablelearning.org/

mmicciolo commented 2 years ago

@franciscastro Ran into this bug during our meeting last week even though I thought I had fixed it. I figured out today how to reproduce it in a different way.

Steps to reproduce.

  1. Open a new tab / window of WLCP
  2. Start a tangrams race instance in the game manager.
  3. Click the home button then click on game player tile
  4. Enter game pin and select player 1. Once it loads click the back button instead of disconnect.
  5. Dont refresh the page.
  6. Click on game player tile again
  7. Enter game pin and select player 1
  8. Shows connecting... text but game still fully works
mmicciolo commented 2 years ago

This issue fixes a bug where the "connecting..." text gets stuck on the screen when re-entering a game without refreshing. This is not an actual connection issue, just an issue with some text not getting cleared.

Testing Steps

Scenario 1

  1. Open a new tab / window of WLCP
  2. Start a tangrams race instance in the game manager.
  3. Click the home button then click on game player tile
  4. Enter game pin and select player 1. Once it loads disconnect.
  5. Dont refresh the page.
  6. Click on game player tile again
  7. Enter game pin and select player 1
  8. Game should reload as expected and "connecting..." text should not get stuck like above.

Scenario 2

  1. Open a new tab / window of WLCP
  2. Start a tangrams race instance in the game manager.
  3. Click the home button then click on game player tile
  4. Enter game pin and select player 1. Once it loads click the back button instead of disconnect.
  5. Dont refresh the page.
  6. Click on game player tile again
  7. Enter game pin and select player 1
  8. Game should reload as expected and "connecting..." text should not get stuck like above.
mmicciolo commented 2 years ago

@apoh3 @geseiche @franciscastro @IvonArroyo @sai-educ

Ready for testing!

apoh3 commented 2 years ago

Tests passed

But... For scenario 1, before disconnecting I received this message saying that the page would refresh. The scenario script specifically asks for the page to not be refreshed. image

sai-educ commented 2 years ago

Test passed on Dev system. However, on new.wearablelearning.org, I've noticed scenario2 (hitting back button) halts on "Connecting...". Tested on Firefox, Safari and Chrome on laptop.

Requesting others to confirm. @franciscastro @geseiche

192

mmicciolo commented 2 years ago

Testing complete.