search

wearefrank / frank-runner

Run any Frank with Tomcat
Apache License 2.0
16 stars 12 forks source link

Update examples because of new features of <Exit> and <Exits> #43

Closed mhdirkse closed 1 year ago

mhdirkse commented 2 years ago

One last time, I examined all the example Frank configs and how they do -s. They are OK now.

mhdirkse commented 1 year ago

In Frank2Example4, we have this:

            <Exits>
                <Exit name="READY" state="SUCCESS" flow:x="1300" flow:y="1000"/>
            </Exits>

This is in file examples/Frank2Example4/src/main/configurations/Hello World/ConfigurationHelloLines.xml.

This exit declaration is not needed for parsing the configuration. Is it necessary for the Frank!Flow? If so, the Frank!Flow may need an update to support omitting the exit.

mhdirkse commented 1 year ago

Jaco once proposed to update our software such that you can omit the Exit but store the x and y coordinates of a shown exit somewhere else. It was decided we do not implement such a feature. Therefore nobody will take action and therefore I close this issue.