search

wearefrank / frank-runner

Run any Frank with Tomcat
Apache License 2.0
16 stars 12 forks source link

Problems running on MAC FR_DIR not resolved properly #72

Closed jjansenvr closed 12 months ago

jjansenvr commented 1 year ago

It looks like on mac the directories are not resolved correctly

FR_DIR="pwd/${BASH_SOURCE%/*}/" in start.sh should have resolved to "/User/m~~r/Projects/frank-runner/"

it resolves to User/m~~r/Projects/MyFirstFrank//User/m~~r/Projects/frank-runner/

image

jjansenvr commented 1 year ago

@jacodg maybe something for Martijn to look in to, No hurry we will fix it manually for now

jjansenvr commented 1 year ago

removing the pwd in FR_DIR="pwd/${BASH_SOURCE%/*}/ in all script solved the first problem

a second problem is having an restart.sh in the project it self restart.sh in the zip (translated from bat file by chatGPT) restart.zip

jacodg commented 1 year ago

For the restart.sh in the project: The path in the documentation was wrong, this is fixed now: https://github.com/ibissource/frank-runner/commit/0be29295effc2acca0225555d058fc990ae212ac

jacodg commented 1 year ago

For the FR_DIR problem. I suppose this happens when running the build.xml in MyFirstFrank using the Task Explorere?

jacodg commented 12 months ago

Should be fixed now: https://github.com/ibissource/frank-runner/blob/8a92e7469e38f7e52391d2a482157447935d21d0/build.xml#L957