search

wearefrank / frank-runner

Run any Frank with Tomcat
Apache License 2.0
16 stars 12 forks source link

Build fails when running edited F!F code with iaf-webapp #88

Closed mhdirkse closed 7 months ago

mhdirkse commented 7 months ago

I did some edits in the F!F sources and tried to run them with specials/iaf-webapp in the Frank!Runner. The build failed with the following error:

[INFO] --- install:3.1.1:install (default-install) @ frankframework-commons ---
[INFO] Installing C:\Users\martijn\temp\frankframework\commons\.flattened-pom.xml to C:\Users\martijn\.m2\repository\org\frankframework\frankframework-commons\8.2.0-SNAPSHOT\frankframework-commons-8.2.0-SNAPSHOT.pom
[INFO] Installing C:\Users\martijn\temp\frankframework\commons\target\frank-runner\frankframework-commons-8.2.0-SNAPSHOT.jar to C:\Users\martijn\.m2\repository\org\frankframework\frankframework-commons\8.2.0-SNAPSHOT\frankframework-commons-8.2.0-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Frank!Framework parent 8.2.0-SNAPSHOT:
[INFO]
[INFO] Frank!Framework parent ............................. SUCCESS [  1.780 s]
[INFO] Frank!Framework Commons ............................ FAILURE [  6.074 s]
[INFO] Frank!Framework Security ........................... SKIPPED
[INFO] CredentialProvider ................................. SKIPPED
[INFO] Frank Management Gateway ........................... SKIPPED
[INFO] Frank!Framework DBMS ............................... SKIPPED
[INFO] Frank!Framework core ............................... SKIPPED
[INFO] Frank!Framework FileSystems ........................ SKIPPED
[INFO] Frank Console ...................................... SKIPPED
[INFO] Frank Console Backend .............................. SKIPPED
[INFO] Frank Console Frontend ............................. SKIPPED
[INFO] Frank Console Webapp ............................... SKIPPED
[INFO] Frank!Framework Larva .............................. SKIPPED
[INFO] Frank!Framework Ladybug ............................ SKIPPED
[INFO] Frank!Framework minimal bundle ..................... SKIPPED
[INFO] Frank!Framework support for Akamai ................. SKIPPED
[INFO] Frank!Framework support for AWS .................... SKIPPED
[INFO] Frank!Framework support for Batch processing ....... SKIPPED
[INFO] Frank!Framework support for Cmis ................... SKIPPED
[INFO] Frank!Framework support for Aspose ................. SKIPPED
[INFO] Special classes for NN ............................. SKIPPED
[INFO] Frank!Framework support for Messaging Systems ...... SKIPPED
[INFO] Frank!Framework support for Kubernetes ............. SKIPPED
[INFO] Frank!Framework support for SAP .................... SKIPPED
[INFO] Frank!Framework support for TIBCO .................. SKIPPED
[INFO] Frank!Framework support for iDIN ................... SKIPPED
[INFO] Frank!Framework full bundle ........................ SKIPPED
[INFO] Frank!Framework webapp ............................. SKIPPED
[INFO] Frank!Framework Test ............................... SKIPPED
[INFO] Frank!Framework example ............................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  8.211 s
[INFO] Finished at: 2024-04-09T15:40:13+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install) on project frankframework-commons: Failed to install artifact org.frankframework:frankframework-commons:jar:8.2.0-SNAPSHOT: C:\Users\martijn\.m2\repository\org\frankframework\frankframework-commons\8.2.0-SNAPSHOT\frankframework-commons-8.2.0-SNAPSHOT.jar.5073711120230172414.tmp -> C:\Users\martijn\.m2\repository\org\frankframework\frankframework-commons\8.2.0-SNAPSHOT\frankframework-commons-8.2.0-SNAPSHOT.jar -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.

Steps to reproduce:

  1. Checkout branch tryingToRunWithIafWebapp of https://github.com/mhdirkse/frankframework
  2. Do a normal Maven build (without Frank!Runner) with Java 17.
  3. In frank-runner/specials/iaf-webapp, add build.properties with the following contents:
# maven.skip.clean=true
maven.skip.tests=true
maven.skip.frankdoc=true
maven.skip.javadoc=true
maven.skip.recompile.all=true
maven.skip.source.jar=true

# Limit the number of IAF modules to build. E.g. when you are working on the core module do the following (it would
# still be a good idea to build all modules after a pull (which might have changed other modules)):
# 
# maven.projects=core
  1. Open a DOS prompt and navigate to frank-runner\specials\iaf-webapp
  2. Execute .\restart.bat

After these steps, the sources of the Frank!Framework were changed as follows:

$ git status
On branch tryingToRunWithIafWebapp
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   console/frontend/src/main/frontend/angular.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        webapp/.gitignore
        webapp/src/main/webapp/WEB-INF/classes/

no changes added to commit (use "git add" and/or "git commit -a")

The Frank!Runner commit was f14928d092c6bc4d400568cc07618f3979f245ad

mhdirkse commented 7 months ago

Fixed by https://github.com/wearefrank/frank-runner/pull/89