search

wearefrank / ladybug-ff-cypress-test

0 stars 0 forks source link

Update for data-cy-debug="tableRow" #17

Closed mhdirkse closed 3 months ago

mhdirkse commented 3 months ago

Ik heb dit op mijn laptop getest. Het gaat in CI/CD pas slagen als er een nieuwe ladybug-frontend release in het FF! zit.

mhdirkse commented 3 months ago

There is no getTableRows command yet. I think it is not a good idea to create it. Using a get or find to query the data-cy tag is only a single statement that is easy to understand. The code does not become easier to understand with the new function, because then you have to read the function body if you want to understand what you are doing.

We already use data-cy* attributes to make the test independent of implementation details.

I also wonder whether debugging will become easier when the test fails. Cypress does not give correct line numbers when showing an error. Can you live with it when I merge this PR?

MarkvdVorst commented 3 months ago

Please fix the failing tests first and then I'll take a look at it again. Just hit the "re-request review" button on top right when you're done and I'll see it pop up in my notifications.

mhdirkse commented 3 months ago

The fix is that the FF! should have the new data-cy* tags. I am working on that.

mhdirkse commented 3 months ago

FF! PR https://github.com/frankframework/frankframework/pull/7264.