search

wearefrank / ladybug-frontend

Frontend for Ladybug
Apache License 2.0
2 stars 7 forks source link

Consider adding a RootLevelReport type #463

Closed philipsens closed 3 months ago

philipsens commented 4 months ago

https://github.com/wearefrank/ladybug-frontend/pull/425#discussion_r1662354121

There are assertions on the XML property of a report to see if it is a report or a top level report. I want to suggest making a partial type or something, to make it more clear that these are two different things.

mhdirkse commented 4 months ago

Ik begrijp dit issue niet. Kunnen rapporten dan genest zijn in de debug tree? En wat voor assertions betreft het hier?

philipsens commented 4 months ago

Ja zoiets. Het als je de gelinkte PR bekijkt is de originele conversatie terug te vinden. https://github.com/wearefrank/ladybug-frontend/pull/425#discussion_r1662354121