search

wearefrank / ladybug-frontend

Frontend for Ladybug
Apache License 2.0
1 stars 7 forks source link

Indentation of nodes in debug tree is not what I expected #467

Closed mhdirkse closed 2 months ago

mhdirkse commented 2 months ago

Indentation of nodes in debug tree is not what I expected. I tested this by running a test adapter that calls another adapter through a JavaListener.

image

image

This applies to all levels of the tree. In the user stories it is written that the checkpoint that closes a group is considered as the last child (story 1020). That would mean that the last child has to appear one position more to the right. And also that it has to disappear when the node is collapsed. If you collapse a node now, you keep the start and the end checkpoint.

This issue can also be fixed by updating story 1020.

MatthijsSmets commented 2 months ago

@jacodg what do you think? Change the user story, or change the indentation?

jacodg commented 2 months ago

I think Martijn has a valid point. Although I would maybe need to see it in a bigger picture. Looking on my local development environment I see the following:

image

Here it seems to be the way Martijn suggests it should be. This is with version 0.0.54.

Dotted lines like in the old Ladybug could possibly make it a lot clearer:

image