search

wearefrank / ladybug-frontend

Frontend for Ladybug
Apache License 2.0
2 stars 7 forks source link

Is "/testtool/transformation[/]?$" still used? #606

Closed jacodg closed 2 months ago

jacodg commented 3 months ago

See https://github.com/wearefrank/ladybug/blob/3440438628668b053ffe125e8cca0cdc6a95d630/src/main/java/nl/nn/testtool/web/ApiAuthorizationFilter.java#L90C64-L90C93 Can we change it to "/testtool/transformation/$"?

Because of "/testtool/transformation[/]?$" I think https://github.com/wearefrank/ladybug/blob/3440438628668b053ffe125e8cca0cdc6a95d630/src/main/java/nl/nn/testtool/web/api/TestToolApi.java#L205 is not used. Can we remove this method?

jacodg commented 2 months ago

You can ignore the second paragraph, it is a GET so it is allowed by https://github.com/wearefrank/ladybug/blob/3440438628668b053ffe125e8cca0cdc6a95d630/src/main/java/nl/nn/testtool/web/ApiAuthorizationFilter.java#L89

jacodg commented 2 months ago

https://github.com/wearefrank/ladybug/commit/4464161a60a6822e0e183314a889f56be27f53df