search

wearefrank / ladybug

Enable users of your application to debug and test it
Apache License 2.0
12 stars 8 forks source link

Ladybug GitHub Actions succeeded even though copyright notices were not OK. #236

Open mhdirkse opened 2 months ago

mhdirkse commented 2 months ago

We observed this here:

Image

mhdirkse commented 2 months ago

@MarkvdVorst suggested that the ladybug backend GitHub test may not test the Maven build of the backend. We know that the ladybug backend tests trigger ladybug-frontend, but that may be the only thing the test does.

MarkvdVorst commented 2 months ago

It would be nice to have a dedicated action for backend testing instead of only having a yaml file for ladybug-frontend tests. I'm guessing the ladybug-frontend yaml also takes the backend into account somehow, but skips the tests copyright and/or unit tests as it did not give me any failed tests earlier when I submitted a PR with wrong copyright year.

MarkvdVorst commented 2 months ago

just noticed that PR #227 would fix this

MarkvdVorst commented 2 months ago

nevermind. the skip copyright is still present in this