search

weareinteractive / ansible-sftp

Ansible role which creates sftp users with chroot environment
MIT License
9 stars 3 forks source link

Not omnipotent #2

Open TvL2386 opened 6 years ago

TvL2386 commented 6 years ago

Hi hi,

I like your role, but I don't like that every invocation will unmount everything. This leads to interruption for sftp users currently logged in and doing stuff in the mnt folder. Also if the playbook breaks after unmount and before the "mount all" handler has been ran, the server will be left in a broken state. All sftp_users won't have there mounts.

franklinkim commented 6 years ago

Hi,

yes, you're correct about the part that this role unmounts all previous folders. It's kind of a lazy way to spare me the need to define folders that you want "not to be mounted" once they have been defined if you understand what I mean (sort of hard reset instead).

Any PR are always welcome.