search

wearejust / grumphp-extra-tasks

A set of extra tasks for grumphp
MIT License
23 stars 6 forks source link

Amend fixed files to the commit #5

Closed PatchRanger closed 7 years ago

PatchRanger commented 7 years ago

Responds to https://github.com/wearejust/grumphp-extra-tasks/pull/4#issuecomment-311777167 .

PatchRanger commented 7 years ago

@ceesvanegmond Sorry, can't reproduce the situation you described in https://github.com/wearejust/grumphp-extra-tasks/pull/4#issuecomment-311777167 . It works without any additional manipulations. It shows red cross instead of green check - yes, because code styling was needed to be fixed. But nevertheless the "woodcutter" is green - because he succeeded to fix the code style issues. All of the changes, introduced to the code, are added to the same commit.

In my view everything works as desired. I see no need in such change. Let me close it now.