search

wearemakery / kotlin-composable-architecture

Companion for the Swift Composable Architecture. A library for building applications in a consistent and understandable way, with composition, testing, and ergonomics in mind.
MIT License
125 stars 13 forks source link

Behaviour of `sink` is different to Swift TCA #5

Open allforabit opened 3 years ago

allforabit commented 3 years ago

Hi there, I was delighted to see that some work has started on porting the composable architecture to Kotlin. It looks great. Have just started playing around with it by copying and pasting some of the code to try the basic idea. I noticed that effects processing behaves a little different to Swift TCA. This processes one value at a time as it's received from the flow. However in the version here it uses .toList which means the flow will have to complete before any actions are sent back into the store.

humblehacker commented 2 years ago

In case anyone's interested, I've attempted a fix for this in my fork.