Closed VirgiliuC closed 1 year ago
Wow thanks! Only just noticed this PR - will be reviewing it over the next few days.
Maybe should close this one and re-issue it, because since then we have further developed the code in this regard, fixed more bugs and added some other required functionality/behaviour. Happy to do that, if you would like.
OK, aborted review - some comments on what I'd looked at. big one being ignoring eslint on ./src!
TBH, we'd be keeping this on a feature branch for a while anyway - we need to support iOS 13 for now - which doesn't support WebGL2.
Our main use case for this library at the moment is single image radiographs, and any loss of resolution in 2d rendering capability would be unacceptable for us, maybe there is a way of combining both solutions. Interested to know the 3d limitation?
The way we use this library is also to BLT the output on to a separate, canvas - which we render tools, overlays, perform zoom on etc. Like to know some more about your use case, do you need to draw tools etc between the z orders of your images? do you need to view the image(s) in different planes?
Certainly interested in the series bugfixes.
To answer your questions:
WebGL2 comes in at iOS15 - so within the next 1-2 years will be happy to drop 1.
I'll close this PR then, and feel free to open another. Certainly interested in future collaboration here.
We have refactored dicom.ts for working with WebGL2, introducing significant changes into the code, while keeping as much as possible the structure and the interfaces. Webgl2 is available on many mobile devices too, and is crucial for modern Dicom images rendering and MPR. We envisage using it as such in our clinical environment. In a nutshell: