wearepal / data-science-types

Mypy stubs, i.e., type information, for numpy, pandas and matplotlib
Apache License 2.0
202 stars 51 forks source link

Tests failing on forking #175

Open adimyth opened 3 years ago

adimyth commented 3 years ago

I forked the repo and ran the tests - ./check_all.sh, it resulted in 152 errors found in 4 files. How to get started?

tmke8 commented 3 years ago

I think you need to first run

pip install -e .

in the main directory of the repository. I will add something about this to the README.

adimyth commented 3 years ago

I had tried with pip install -e . "[dev]" as mentioned in your contributing section in README. But that doesn't worked either!

tmke8 commented 3 years ago

Do the errors look like this?

tests/pandas_test.py:3: error: Skipping analyzing 'pandas': found module but no type hints or library stubs
tests/pandas_test.py:4: error: Skipping analyzing 'numpy': found module but no type hints or library stubs
tests/pandas_test.py:6: error: Constraint 1 becomes "Any" due to an unfollowed import
tests/pandas_test.py:6: error: Constraint 2 becomes "Any" due to an unfollowed import
tests/pandas_test.py:9: error: Argument 1 to "assert_type" becomes "Any" due to an unfollowed import
tests/pandas_test.py:9: error: Argument 2 to "assert_type" becomes "Type[Any]" due to an unfollowed import
tests/pandas_test.py:13: error: Type of variable becomes "Any" due to an unfollowed import
tests/pandas_test.py:14: error: Type of variable becomes "Any" due to an unfollowed import
...
tests/matplotlib_test.py:10: error: Type of variable becomes "List[List[Any]]" due to an unfollowed import
Found 151 errors in 3 files (checked 3 source files)
adimyth commented 3 years ago

Yes, similar to this!

TheCleric commented 3 years ago

@adimyth not sure if it makes a difference but I run pip install -e .[dev] (notice the small difference from what you mentioned) and do not see this issue.