Add Pandas to_parquet signature

wearepal / data-science-types

Mypy stubs, i.e., type information, for numpy, pandas and matplotlib

Apache License 2.0

202 stars 51 forks source link

Add Pandas to_parquet signature #192

Closed jmargeta closed 3 years ago

jmargeta commented 3 years ago

Adding signature for DataFrame.to_parquet(...) https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.to_parquet.html

This method requires either fastparquet or pyarrow to be installed. They are not supported on 3.9, yet.

Shall I remove the test completely?

See also: pyarrow: https://github.com/apache/arrow/pull/8386 numba (which fastparquet depends on): https://github.com/numba/numba/issues/6345

tmke8 commented 3 years ago

Hm, yeah, remove the test. Or, though this is maybe a bit unusual, could you comment it out and put a comment above it, which says to uncomment it when Python 3.9 support improves? It's also possible to mark tests to be skipped for certain python versions, but this might be overly complicated.

jmargeta commented 3 years ago

Thanks for your feedback, @thomkeh, that sounds good. The PR should now contain only the signature.

tmke8 commented 3 years ago

Perfect, thanks!