Add stubs for to_pickle and read_pickle

wearepal / data-science-types

Mypy stubs, i.e., type information, for numpy, pandas and matplotlib

Apache License 2.0

202 stars 52 forks source link

Closed EdwardJRoss closed 3 years ago

EdwardJRoss commented 3 years ago

Resolves #216

tmke8 commented 3 years ago

So it seems the tests for python 3.9 are downloading a newer version of pandas (1.2) which has the problem mentioned in #215. Is it easy to fix that?

tmke8 commented 3 years ago

I'm actually a bit surprised that pandas already dropped python 3.6 support.

EdwardJRoss commented 3 years ago

I guess a workaround would be to use the previous version in the tests by updating .github/workflows/test_correctness.yml to install pandas<1.2

I'm not really clear enough on iloc behaviour and the test intention on how to fix the test for Pandas 1.2.

tmke8 commented 3 years ago

Okay, then let's do this for now

updating .github/workflows/test_correctness.yml to install pandas<1.2

You can just edit the file.

tmke8 commented 3 years ago

Great, thanks!