Open joelwmale opened 2 months ago
This package was inherited and not changed too much to ensure backward compatibility.
I suggest updating some function names to have them make more sense, and deprecate the old ones to be removed in the next major update.
Some examples:
public function condition(array|CartCondition $condition): self -> public function addCondition(CartCondition $condition): self
public function condition(array|CartCondition $condition): self
public function addCondition(CartCondition $condition): self
This package was inherited and not changed too much to ensure backward compatibility.
I suggest updating some function names to have them make more sense, and deprecate the old ones to be removed in the next major update.
Some examples:
public function condition(array|CartCondition $condition): self->public function addCondition(CartCondition $condition): self